Minor refactor

Protect against a NULL pointer dereference, and remove unused write to a variable.
redis · Sep 8, 2022 · 560e664 · 560e664
1 parent d756f68
commit 560e664
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/hiredis.c b/hiredis.c
@@ -747,7 +747,7 @@ void redisFree(redisContext *c) {
     if (c->privdata && c->free_privdata)
         c->free_privdata(c->privdata);
 
-    if (c->funcs->free_privctx)
+    if (c->funcs && c->funcs->free_privctx)
         c->funcs->free_privctx(c->privctx);
 
     memset(c, 0xff, sizeof(*c));

diff --git a/test.c b/test.c
@@ -1999,7 +1999,7 @@ static void connectCallback(redisAsyncContext *c, int status) {
     }
     else if (t->testno == ASTEST_ISSUE_931_PING)
     {
-        status = redisAsyncCommand(c, commandCallback, NULL, "PING");
+        redisAsyncCommand(c, commandCallback, NULL, "PING");
     }
 }
 static void disconnectCallback(const redisAsyncContext *c, int status) {