Accept -nan per the RESP3 spec recommendation.

For reference: https://github.com/redis/redis-specifications/blob/master/protocol/RESP3.md
redis · Apr 14, 2023 · 563b062 · 563b062
1 parent 04c1b5b
commit 563b062
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/read.c b/read.c
@@ -303,7 +303,8 @@ static int processLineItem(redisReader *r) {
                 d = INFINITY; /* Positive infinite. */
             } else if (len == 4 && strcasecmp(buf,"-inf") == 0) {
                 d = -INFINITY; /* Negative infinite. */
-            } else if (len == 3 && strcasecmp(buf,"nan") == 0) {
+            } else if ((len == 3 && strcasecmp(buf,"nan") == 0) ||
+                       (len == 4 && strcasecmp(buf, "-nan") == 0)) {
                 d = NAN; /* nan. */
             } else {
                 d = strtod((char*)buf,&eptr);

diff --git a/test.c b/test.c
@@ -684,6 +684,16 @@ static void test_reply_reader(void) {
     freeReplyObject(reply);
     redisReaderFree(reader);
 
+    test("Correctly parses RESP3 double -Nan: ");
+    reader = redisReaderCreate();
+    redisReaderFeed(reader, ",-nan\r\n", 7);
+    ret = redisReaderGetReply(reader, &reply);
+    test_cond(ret == REDIS_OK &&
+              ((redisReply*)reply)->type == REDIS_REPLY_DOUBLE &&
+              isnan(((redisReply*)reply)->dval));
+    freeReplyObject(reply);
+    redisReaderFree(reader);
+
     test("Can parse RESP3 nil: ");
     reader = redisReaderCreate();
     redisReaderFeed(reader, "_\r\n",3);