Skip to content

Commit

Permalink
Do store command timeout in the context for redisSetTimeout (#593)
Browse files Browse the repository at this point in the history
  • Loading branch information
catterer authored and michael-grunder committed Aug 29, 2022
1 parent c57cad6 commit a4c8254
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions net.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
/* Defined in hiredis.c */
void __redisSetError(redisContext *c, int type, const char *str);

int redisContextUpdateCommandTimeout(redisContext *c, const struct timeval *timeout);

void redisNetClose(redisContext *c) {
if (c && c->fd != REDIS_INVALID_FD) {
close(c->fd);
Expand Down Expand Up @@ -333,6 +335,10 @@ int redisContextSetTimeout(redisContext *c, const struct timeval tv) {
const void *to_ptr = &tv;
size_t to_sz = sizeof(tv);

if (redisContextUpdateCommandTimeout(c, &tv) != REDIS_OK) {
__redisSetError(c, REDIS_ERR_OOM, "Out of memory");
return REDIS_ERR;
}
if (setsockopt(c->fd,SOL_SOCKET,SO_RCVTIMEO,to_ptr,to_sz) == -1) {
__redisSetErrorFromErrno(c,REDIS_ERR_IO,"setsockopt(SO_RCVTIMEO)");
return REDIS_ERR;
Expand Down
9 changes: 9 additions & 0 deletions test.c
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,13 @@ static void test_blocking_connection_timeouts(struct config config) {
test("Does not return a reply when the command times out: ");
if (detect_debug_sleep(c)) {
redisAppendFormattedCommand(c, sleep_cmd, strlen(sleep_cmd));

// flush connection buffer without waiting for the reply
s = c->funcs->write(c);
assert(s == (ssize_t)sdslen(c->obuf));
sdsfree(c->obuf);
c->obuf = sdsempty();

tv.tv_sec = 0;
tv.tv_usec = 10000;
redisSetTimeout(c, tv);
Expand All @@ -1169,6 +1175,9 @@ static void test_blocking_connection_timeouts(struct config config) {
strcmp(c->errstr, "recv timeout") == 0);
#endif
freeReplyObject(reply);

// wait for the DEBUG SLEEP to complete so that Redis server is unblocked for the following tests
sleep(3);
} else {
test_skipped();
}
Expand Down

0 comments on commit a4c8254

Please sign in to comment.