Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: set CMAKE_CONF_INSTALL_DIR to lib/cmake/hiredis. #1048

Closed
wants to merge 1 commit into from

Conversation

cyfdecyf
Copy link

Installing cmake modules to <PREFIX>/lib/cmake/ is more common and make it easy for users to use hiredis package.

If backwards compatibility should be kept, maybe we can install to both share/hiredis and lib/cmake/hiredis.

@chayim
Copy link
Contributor

chayim commented Sep 1, 2022

@cyfdecyf In light of this PR I think this needs revisiting. WDYT?

@cyfdecyf
Copy link
Author

cyfdecyf commented Sep 1, 2022

I'll close this PR because find_package(hiredis) works with cmake configs files installing to share/hiredis.

I can't remember if I encounter any problem when I submit this PR. But seems the cmake doc about find_package search directory is right so share/hiredis can be used.

@cyfdecyf cyfdecyf closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants