Embed debug information in windows static .lib file #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdb file Using .pdb files with .lib files on windows is very inconvenient, particularly if the .lib file is then linked as part of a different .dll. Chances are that the original .pdb will not be picked up or distributed along with the tooling.
|
Merged, thanks! |
bjosv
added a commit
to Nordix/hiredis
that referenced
this pull request
Sep 15, 2022
From ff57c18 (redis#1054) the debug information was embedded in the windows static lib rather than creating a .pdb file. Removing the installation step of this file in CMake.
bjosv
added a commit
to Nordix/hiredis
that referenced
this pull request
Sep 15, 2022
From ff57c18 (redis#1054) the debug information was embedded in the windows static lib rather than creating a .pdb file. Removing the installation step of this file in CMake when building with buildtype Debug or RelWithDebInfo.
bjosv
added a commit
to Nordix/hiredis
that referenced
this pull request
Sep 15, 2022
See ff57c18 (redis#1054) for same change in library hiredis_static.
michael-grunder
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Remove attempt to install .pdb file for windows static lib From ff57c18 (#1054) the debug information was embedded in the windows static lib rather than creating a .pdb file. Removing the installation step of this file in CMake when building with buildtype Debug or RelWithDebInfo. * Embed debug information in windows hiredis_ssl_static lib See ff57c18 (#1054) for same change in library hiredis_static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed debug information in windows static lib, rather than create a pdb fileþ
Using .pdb files with .lib files on windows is very inconvenient, particularly if the .lib
file is then linked as part of a different .dll. Chances are that the original .pdb
will not be picked up or distributed along with the tooling.