Use a windows specific keepalive function. #1103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is possible to toggle `TCP_KEEPALIVE` in windows via setsockopt, you have to use `WSAIoctl` to set the interval. Since `WSAIoctl` can actually do all of this in one call (toggle the option, and set the corresponding interval), just use that in Windows and avoid the call to `setsockopt` alltogether. See: redis#1100
|
cc @kristjanvalur @bjosv I haven't used a Windows machine in ten years, so if either of you happens to know Windows feel free to let me know if there's something incorrect in this PR. I just based it on their online docs. |
michael-grunder
force-pushed
the
win32-keepalive
branch
from
31822c8
to
e377906
Compare
|
GitHub got confused by this commit. See #1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to toggle
SO_KEEPALIVEin windows viasetsockopt, you have to useWSAIoctlto set the interval.Since
WSAIoctlcan actually do all of this in one call (toggle theoption, and set the corresponding interval), just use that in Windows
and avoid the call to
setsockoptalltogether.See: #1100