Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake corrections for building on Windows #1122

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

bjosv
Copy link
Contributor

@bjosv bjosv commented Sep 28, 2022

Visual Studio generator will replace -D with /D.
Flag is not available on a GNU compilator running on windows,
like in a mingw64 setup.
@bjosv
Copy link
Contributor Author

bjosv commented Sep 28, 2022

@SRyabinin @kristjanvalur My testing seems fine, but please check if reasonable.

@kristjanvalur
Copy link
Contributor

Looks reasonable. Btw, I'm not in any way a CMake expert, I have just sort of tried to do my best to make things work :)

@bjosv
Copy link
Contributor Author

bjosv commented Sep 29, 2022

CMake covers so many targets and options, so in parts we have to go with trial and error I guess..and a lot of googling :)

@michael-grunder michael-grunder merged commit c245df9 into redis:master Sep 29, 2022
@michael-grunder
Copy link
Collaborator

Merged, thanks!

Also from where I'm sitting you are both CMake gurus 😄

@bjosv bjosv deleted the windows-cmake branch September 29, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The features used are not compatible with the specified minimum version of cmake 3.0 for WIN32.
3 participants