Update async.c to handle segfaults for async connections #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing the amateur hour redis free code
zeekling
reviewed
Nov 5, 2022
| @@ -360,6 +360,8 @@ static void __redisRunDisconnectCallback(redisAsyncContext *ac, int status) | |||
|
|
|||
| /* Helper function to free the context. */ | |||
| static void __redisAsyncFree(redisAsyncContext *ac) { | |||
| if (!ac) return; | |||
I'm not inclined to merge this PR with that commit message. The fact that it's obnoxious aside, it's useless in a See 21a1207 for a better example. I'm tagging v1.1.0-rc1 tonight, so feel free to resubmit with a helpful commit message and I will get it merged and into the release. |
Comment on lines
+418
to
+419
| if (!ac) return; | ||
|
|
There was a problem hiding this comment.
Please remove whitespace.
| @@ -360,6 +360,8 @@ static void __redisRunDisconnectCallback(redisAsyncContext *ac, int status) | |||
|
|
|||
| /* Helper function to free the context. */ | |||
| static void __redisAsyncFree(redisAsyncContext *ac) { | |||
| if (!ac) return; | |||
|
|
|||
|
Closing in favor of #1135 |
|
sorry for the tone, this issue caused a problem with production code. good to see it is implemented |
|
No worries, we've all been there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the amateur hour redis free code