Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapters/libhv #904

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Add adapters/libhv #904

merged 1 commit into from
Sep 7, 2022

Conversation

ithewei
Copy link

@ithewei ithewei commented Dec 23, 2020

Build steps:

git clone https://github.com/ithewei/libhv
cd libhv
./configure && make && sudo make install

git clone -b libhv https://github.com/ithewei/hiredis
cd hiredis
mkdir build
cd build
cmake .. -DENABLE_EXAMPLES=ON
make
./examples/example-libhv

output:

Connected...
argv[end-1]: ./examples/example-libhv
Disconnected...

@michael-grunder
Copy link
Collaborator

michael-grunder commented Sep 7, 2022

This PR looks good to me, but I can't find a great deal of information about libhv on the web, other than it has almost 5000 stars on GitHub.

@bjosv Any thoughts? I don't really see a downside to adding another adapter. If we merge it I'll update the Makefile too so it can build the example as well.

@bjosv
Copy link
Contributor

bjosv commented Sep 7, 2022

I have tested the example and it works fine to build and run, so LGTM!

ac->ev.addWrite = redisLibhvAddWrite;
ac->ev.delWrite = redisLibhvDelWrite;
ac->ev.cleanup = redisLibhvCleanup;
ac->ev.data = io;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter is not supporting timeouts via ac->ev.scheduleTimer, but I guess that's ok.
It's only supported by 4 of the 9 current adapters.

@michael-grunder michael-grunder merged commit a669167 into redis:master Sep 7, 2022
michael-grunder added a commit that referenced this pull request Sep 7, 2022
michael-grunder added a commit that referenced this pull request Sep 7, 2022
michael-grunder added a commit that referenced this pull request Sep 8, 2022
michael-grunder added a commit that referenced this pull request Sep 13, 2022
michael-grunder added a commit that referenced this pull request Sep 21, 2022
Add timeout support to libhv adapter.

See: #904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants