Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI workflow for hiredis: Arm, Arm64, 386, windows. #943

Merged
merged 6 commits into from
Aug 29, 2022

Conversation

kristjanvalur
Copy link
Contributor

This builds and tests hiredis using Github Actions.
This allows convenient verification of pull requests, and thus augments the Travis CI pipeiline.
There are:

  • Full build tests and unit for AMD64/linux
  • simple build tests and unit tests for i386, arm and aarch64 linux platforms
  • simple build tests and unit tests for windows

@kristjanvalur
Copy link
Contributor Author

I've updated this PR. Since I submitted this PR 8 months ago, upstream has added its own Github actions.
However, this PR still contains several relevant things:

  1. test 32 bit support
  2. Test ARM support, 32 and 64 bit
  3. Use of containers to provide redis server.

If there is interest, I can re-craft this to at least add the 32 bit and ARM tests to the existing set of tests.

@kristjanvalur
Copy link
Contributor Author

Hello there, any news?

@kristjanvalur
Copy link
Contributor Author

Rebased and collapsed this PR into separate chuncs. test.sh can now run a redis server as a docker container for simplicity. Use matrix tests with emulators in test.yml to test for ARM. Test for windows. Test linux 32 bit builds.

@kristjanvalur kristjanvalur changed the title Add Github Actions CI workflow for hiredis Add Github Actions CI workflow for hiredis: Arm, Arm64, 386, windows. Aug 19, 2022
@michael-grunder michael-grunder merged commit 8491a65 into redis:master Aug 29, 2022
@kristjanvalur kristjanvalur deleted the pr7 branch August 30, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants