Added REDIS_NO_AUTO_FREE_REPLIES flag #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new flag can be set on the redisOptions struct and given to the async connection. If set, the new flag makes sure the replies given to the async callback will not be freed by hiredis. Instead, the reply ownership is given to the callback and it's the user's responsibility to free it when he finished using it.
async.c
Outdated
| @@ -569,7 +569,9 @@ void redisProcessCallbacks(redisAsyncContext *ac) { | |||
|
|
|||
| if (cb.fn != NULL) { | |||
| __redisRunCallback(ac,&cb,reply); | |||
| c->reader->fn->freeObject(reply); | |||
| if (!(c->flags & REDIS_NO_AUTO_FREE_REPLIES)){ | |||
| c->reader->fn->freeObject(reply); | |||
There was a problem hiding this comment.
Just a whitespace change (4 space indentation)
|
Thanks for the PR! This is a useful addition and small enough a change that we can probably get it in v1.0.1. I'll also play around with how we might want this flag to work for |
Co-authored-by: Michael Grunder <michael.grunder@gmail.com>
|
@michael-grunder anything else you want me to change/add here? |
|
Nope, I think it's good. I'll get it merged over the weekend. |
|
Merged, thanks! (and sorry for the delay) |
dlazar-dn
pushed a commit
to dlazar-dn/hiredis
that referenced
this pull request
Sep 30, 2021
When set hiredis will not automatically free replies in an async context, and the replies must be freed instead by the user. Co-authored-by: Michael Grunder <michael.grunder@gmail.com>
dlazar-dn
pushed a commit
to dlazar-dn/hiredis
that referenced
this pull request
Dec 22, 2021
When set hiredis will not automatically free replies in an async context, and the replies must be freed instead by the user. Co-authored-by: Michael Grunder <michael.grunder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flag can be set on the redisOptions struct and given to the async connection. If set, the new flag makes sure the replies given to the async callback will not be freed by hiredis. Instead, the reply ownership is given to the callback and it's the user's
responsibility to free it when he finished using it.