Ensure closing connection in Pipeline (#3865)

even if there is an error in sync method.
redis · Jul 11, 2024 · 287d743 · 287d743
1 parent 1c13877
commit 287d743
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/main/java/redis/clients/jedis/Pipeline.java b/src/main/java/redis/clients/jedis/Pipeline.java
@@ -10,6 +10,7 @@
 import redis.clients.jedis.exceptions.JedisDataException;
 import redis.clients.jedis.graph.GraphCommandObjects;
 import redis.clients.jedis.params.*;
+import redis.clients.jedis.util.IOUtils;
 import redis.clients.jedis.util.KeyValue;
 
 public class Pipeline extends PipelineBase implements DatabasePipelineCommands, Closeable {
@@ -46,10 +47,12 @@ public final <T> Response<T> appendCommand(CommandObject<T> commandObject) {
 
   @Override
   public void close() {
-    sync();
-
-    if (closeConnection) {
-      connection.close();
+    try {
+      sync();
+    } finally {
+      if (closeConnection) {
+        IOUtils.closeQuietly(connection);
+      }
     }
   }