Adding one test in JedisPoolWithCompleteCredentialsTest

redis · Dec 23, 2020 · 8910513 · 8910513
1 parent 406dfa1
commit 8910513
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 9 deletions.
diff --git a/src/test/java/redis/clients/jedis/tests/JedisPoolTest.java b/src/test/java/redis/clients/jedis/tests/JedisPoolTest.java
@@ -62,7 +62,7 @@ public void checkConnectionWithDefaultPort() {
   }
 
   @Test
-  public void checkResourceIsClosebleAndReusable() {
+  public void checkResourceIsClosableAndReusable() {
     GenericObjectPoolConfig config = new GenericObjectPoolConfig();
     config.setMaxTotal(1);
     config.setBlockWhenExhausted(false);
@@ -88,15 +88,15 @@ public void checkResourceIsClosebleAndReusable() {
   @Test
   public void checkPoolRepairedWhenJedisIsBroken() {
     JedisPool pool = new JedisPool(new JedisPoolConfig(), hnp.getHost(), hnp.getPort());
-    Jedis jedis = pool.getResource();
-    jedis.auth("foobared");
-    jedis.quit();
-    jedis.close();
+    try (Jedis jedis = pool.getResource()) {
+      jedis.auth("foobared");
+      jedis.quit();
+    }
 
-    jedis = pool.getResource();
-    jedis.auth("foobared");
-    jedis.incr("foo");
-    jedis.close();
+    try (Jedis jedis = pool.getResource()) {
+      jedis.auth("foobared");
+      jedis.incr("foo");
+    }
     pool.destroy();
     assertTrue(pool.isClosed());
   }

diff --git a/src/test/java/redis/clients/jedis/tests/JedisPoolWithCompleteCredentialsTest.java b/src/test/java/redis/clients/jedis/tests/JedisPoolWithCompleteCredentialsTest.java
@@ -92,6 +92,23 @@ public void checkResourceIsClosableAndReusable() {
     }
   }
 
+  @Test
+  public void checkPoolRepairedWhenJedisIsBroken() {
+    JedisPool pool = new JedisPool(new JedisPoolConfig(), hnp.getHost(), hnp.getPort(),
+        Protocol.DEFAULT_TIMEOUT, Protocol.DEFAULT_TIMEOUT, 0 /*infinite*/, "acljedis", "fizzbuzz",
+        Protocol.DEFAULT_DATABASE, "repairable-pool");
+    try (Jedis jedis = pool.getResource()) {
+      jedis.quit();
+    }
+
+    try (Jedis jedis = pool.getResource()) {
+      jedis.auth("foobared");
+      jedis.incr("foo");
+    }
+    pool.destroy();
+    assertTrue(pool.isClosed());
+  }
+
   @Test(expected = JedisExhaustedPoolException.class)
   public void checkPoolOverflow() {
     GenericObjectPoolConfig config = new GenericObjectPoolConfig();