Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring connection pool to MultiClusterPooledConnectionProvider #3753

Closed
jarkus4 opened this issue Mar 4, 2024 · 4 comments · Fixed by #3801
Closed

Comments

@jarkus4
Copy link

jarkus4 commented Mar 4, 2024

Currently MultiClusterPooledConnectionProvider (redis.clients.jedis.providers.MultiClusterPooledConnectionProvider) creates new instance of ConnectionPool for each of configured clusters (MultiClusterClientConfig.GetClusterConfig()). This pool is created without providing any pool specific configuration (using constructor without JedisPoolConfig param), making it impossible to specify a number of pool specific settings eg maximum number of connections.

Please add possibility of passing JedisPoolConfig to be used during construction of those pools, preferably on the per cluster basis (ClusterConfig seems like a fitting place to pass it, but Im not sure)

@traitsisgiorgos
Copy link

hi, I am a new contributor. Can you give same more info about the request?

@jarkus4
Copy link
Author

jarkus4 commented Mar 20, 2024

What kind of info do you need?

I would like to be able to set optional JedisPoolConfig member in ClusterConfig object (just as I set HostAndPort and JedisClientConfig). Then if its set it should be passed on when creating ConnectionPool for this cluster (as an additional constructor parameter compared to current one).

If you are asking about how to use MultiClusterPooledConnectionProvider in general its basic documentation is here: https://github.com/redis/jedis/blob/master/docs/failover.md

@thachlp
Copy link
Contributor

thachlp commented Apr 6, 2024

Hi, I am also a new contributor 🤩
@sazzad16 @jarkus4 @traitsisgiorgos please help review my pr 🙇

@sazzad16 sazzad16 added this to the 5.2.0 milestone Apr 10, 2024
@sazzad16
Copy link
Collaborator

Resolved by #3801

@sazzad16 sazzad16 modified the milestones: 5.2.0, 5.1.3 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants