Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom connection pool to MultiClusterPooledConnectionProvider #3801

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Custom connection pool to MultiClusterPooledConnectionProvider #3801

merged 8 commits into from
Apr 18, 2024

Conversation

thachlp
Copy link
Contributor

@thachlp thachlp commented Apr 5, 2024

Issue: #3753

@sazzad16 sazzad16 added this to the 5.2.0 milestone Apr 10, 2024
sazzad16
sazzad16 requested changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I reviewed this some time ago. Just now I've realized I never submitted it.

src/main/java/redis/clients/jedis/MultiClusterClientConfig.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/MultiClusterClientConfig.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/providers/MultiClusterPooledConnectionProvider.java Outdated Show resolved Hide resolved
src/test/java/redis/clients/jedis/providers/MultiClusterPooledConnectionProviderTest.java Outdated Show resolved Hide resolved
thachlp and others added 3 commits April 17, 2024 17:43
@thachlp @sazzad16
Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java
f0426e4 
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@thachlp @sazzad16
Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java
faf957a 
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@thachlp
Update test
c9ed879
@thachlp thachlp requested a review from sazzad16 April 17, 2024 11:16
@sazzad16 sazzad16 changed the title Add support for configuring connection pool to MultiClusterPooledConnectionProvider Custom connection pool to MultiClusterPooledConnectionProvider Apr 17, 2024
thachlp and others added 2 commits April 17, 2024 20:32
@thachlp @sazzad16
Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java
7abe900 
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@thachlp @sazzad16
Update src/test/java/redis/clients/jedis/providers/MultiClusterPooled…
09afb9f 
…ConnectionProviderTest.java

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@thachlp thachlp requested a review from sazzad16 April 17, 2024 13:32
@sazzad16 sazzad16 merged commit 4a85d11 into redis:master Apr 18, 2024
5 checks passed
@thachlp thachlp deleted the add-support-connection-pool-to-connection-provider branch April 18, 2024 08:41
@sazzad16 sazzad16 linked an issue Apr 18, 2024 that may be closed by this pull request
Add support for configuring connection pool to MultiClusterPooledConnectionProvider #3753
Closed
@sazzad16 sazzad16 mentioned this pull request Apr 18, 2024
Closed
@sazzad16
Copy link
Collaborator

Merged.

Thanks @thachlp for your contribution.

@thachlp
Copy link
Contributor Author

thachlp commented Apr 18, 2024

Thanks @sazzad16

sazzad16 added a commit that referenced this pull request May 20, 2024
@thachlp @sazzad16
Custom connection pool to MultiClusterPooledConnectionProvider (#3801)
fd2c5e7 
* Add support for configuring connection pool to MultiClusterPooledConnectionProvider

* Add ClusterConfig constructor to include ConnectionPoolConfig, add test

* Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Update test

* Update src/main/java/redis/clients/jedis/MultiClusterClientConfig.java

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Update src/test/java/redis/clients/jedis/providers/MultiClusterPooledConnectionProviderTest.java

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Format testConnectionPoolConfigApplied

---------

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@sazzad16 sazzad16 modified the milestones: 5.2.0, 5.1.3 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.

Add support for configuring connection pool to MultiClusterPooledConnectionProvider
2 participants
@thachlp @sazzad16