Implement fix in JedisPubSub to support PING/PONG during subscription. #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM. Once another reviewer approves we can merge. |
|
LGTM, too. Thanks for the contribution. |
HeartSaVioR
pushed a commit
that referenced
this pull request
May 13, 2016
HeartSaVioR
pushed a commit
that referenced
this pull request
May 13, 2016
|
Merged to master, 2.8, 2.9 branches respectively! |
|
@marcosnils, @HeartSaVioR Hi guys, thanks for reviewing and merging ! Do you have any plans to release any time soon ? |
|
It would be perfect if BinaryJedisPubSub also have this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to change pom.xml in order to pass the javadoc generation.
[...]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:35 min
[INFO] Finished at: 2016-05-12T16:39:27+03:00
[INFO] Final Memory: 24M/60M
[INFO] ------------------------------------------------------------------------
make stop
[...]