Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the logic that prevents all cluster slot requests sent to specific instances #1928

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

petpetg
Copy link
Contributor

@petpetg petpetg commented Jan 9, 2019

Fixed the logic that prevents all cluster slot requests sent to specific instances when jedis is initialized on many processes(such as storm with a lot of works).
It can cause high CPU and the impact of many slow queries.

Please review.
thanks.

…fic instances when jedis is initialized on many processes(such as storm with a lot of works), It can cause high CPU and the impact of many slow queries.
@petpetg
Copy link
Contributor Author

petpetg commented Jan 9, 2019

When the amount of requests is large, it will result in high CPU and a lot of slow queries.

@petpetg
Copy link
Contributor Author

petpetg commented Jan 9, 2019

When a storm application with 200 workers is started, the CPU utilization of one instance exceeds 20%, while that of the other instances is only 2%. At the same time, there will be a lot of requests blocked and slow queries.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace each tab with two spaces.

@sazzad16 sazzad16 added this to the 3.0.2 milestone Jan 9, 2019
@petpetg
Copy link
Contributor Author

petpetg commented Jan 10, 2019

Hi @sazzad16
This changed was fixed the logic that prevents all cluster slot requests sent to specific instances when jedis is initialized on many processes(such as storm with a lot of works). It can cause high CPU and the impact of many slow queries.
When a storm application with 200 workers is started, the CPU utilization of one instance exceeds 20%, while that of the other instances is only 2%. At the same time, there will be a lot of requests blocked and slow queries.

Please review.
thanks.

@sazzad16
Copy link
Collaborator

@petpetg I understand and I already reviewed. Please address what was said in the review. Thx!

@petpetg
Copy link
Contributor Author

petpetg commented Jan 10, 2019

@sazzad16 Done. Thx!

@gkorland
Copy link
Contributor

It feels like shuffle might be a too "heavy" solution for this, should we just let each client randomly start to iterate the node from a different place?

@sazzad16 sazzad16 changed the title Fixed the logic that prevents all cluster slot requests sent to specific instances when jedis is initialized on many processes(such as storm with a lot of works) Fixed the logic that prevents all cluster slot requests sent to specific instances Jun 29, 2019
@sazzad16 sazzad16 modified the milestones: 3.0.2, 3.2.0 Jul 15, 2019
@sazzad16 sazzad16 modified the milestones: 3.2.0, 3.3.0 Nov 25, 2019
@sazzad16 sazzad16 modified the milestones: 3.3.0, 3.4.0 Mar 14, 2020
@sazzad16 sazzad16 modified the milestones: 3.4.0, 3.5.0 Nov 26, 2020
@sazzad16 sazzad16 modified the milestone: 3.5.0 Dec 9, 2020
@sazzad16 sazzad16 modified the milestones: 3.5.0, 3.6.0 Jan 19, 2021
@gkorland gkorland requested a review from dengliming March 24, 2021 08:16
dengliming
dengliming previously approved these changes Mar 24, 2021
@dengliming dengliming requested a review from sazzad16 March 24, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants