Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Multi or Pipeline check #2031

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jul 22, 2019

First half of solution of #1614

@sazzad16 sazzad16 added this to the 3.1.1 milestone Jul 22, 2019
@sazzad16 sazzad16 requested a review from gkorland July 22, 2019 05:40
@gkorland
Copy link
Contributor

@sazzad16 why is it on 3.1.1? should we move it to 3.2.0?

@sazzad16
Copy link
Collaborator Author

@gkorland

why is it on 3.1.1?

Because it's backwards-compatible bug fix.

should we move it to 3.2.0?

Only if you're plan right now is not to have a release 3.1.1.

PS: In that case, we should drop third number while versioning.

@gkorland
Copy link
Contributor

I think the third number should be used for "service packs" releasing critical bug fixes for existing version.
The second should be used for "feature version"
And the first for major versions with breaking backward compatibility.

If you think this issue is critical bug fix on top of 3.1.0 then it should be part of 3.1.1

@sazzad16
Copy link
Collaborator Author

I saw may be two issues related this. So I won't call it "critical".

Again, if you've decided that bug fix releases would be only for critical bugs, IMHO, it may be off dropping that third number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants