-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2119 Implements GeoRadiusParam.withHash() #2137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangbodong22011
force-pushed
the
feature-geo-withhash
branch
from
February 14, 2020 06:19
9d4352b
to
1cfdf96
Compare
I noticed the tip here.
So I distinguish
|
yangbodong22011
force-pushed
the
feature-geo-withhash
branch
from
February 21, 2020 07:46
1cfdf96
to
5ee29c9
Compare
yangbodong22011
force-pushed
the
feature-geo-withhash
branch
from
February 21, 2020 07:51
5ee29c9
to
6de5033
Compare
@gkorland I have revised it according to your comments, please review. |
sazzad16
requested changes
Feb 21, 2020
src/test/java/redis/clients/jedis/tests/commands/GeoCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/GeoCommandsTest.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
…st.java Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
…st.java Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
sazzad16
reviewed
Mar 2, 2020
sazzad16
approved these changes
Mar 2, 2020
gkorland
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
GeoRadiusParam.withHash()
, Redis sourceaddReplyLongLong(c, gp->score);
, so the score type is long.