Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2119 Implements GeoRadiusParam.withHash() #2137

Merged
merged 5 commits into from
Mar 14, 2020

Conversation

yangbodong22011
Copy link
Collaborator

Implements GeoRadiusParam.withHash(), Redis source addReplyLongLong(c, gp->score);, so the score type is long.

@yangbodong22011
Copy link
Collaborator Author

yangbodong22011 commented Feb 14, 2020

I noticed the tip here.

// Do not add WITHHASH since we can't classify result of WITHHASH and WITHDIST,
// and WITHHASH is for debugging purposes

So I distinguish score and distance by type.

if (info instanceof byte[]) {
    // distance
    resp.setDistance(DOUBLE.build(info));
} else if (info instanceof Long) {
    // score
    resp.setScore(LONG.build(info));
}

@gkorland gkorland linked an issue Feb 20, 2020 that may be closed by this pull request
@yangbodong22011
Copy link
Collaborator Author

@gkorland I have revised it according to your comments, please review.

杨博东 and others added 3 commits February 21, 2020 17:18
Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
…st.java

Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
…st.java

Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
@yangbodong22011
Copy link
Collaborator Author

@sazzad16 @gkorland PING

@sazzad16 sazzad16 requested a review from gkorland March 6, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please implements GeoRadiusParam.withHash() method!
3 participants