-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#2120) GeoRadius support store and storedist option #2140
Conversation
georadiusStore and georadiusByMemberStore
please which version add??
thank you !
…------------------ 原始邮件 ------------------
发件人: "杨博东"<notifications@github.com>;
发送时间: 2020年2月14日(星期五) 下午3:53
收件人: "xetorthio/jedis"<jedis@noreply.github.com>;
抄送: "Subscribed"<subscribed@noreply.github.com>;
主题: [xetorthio/jedis] (#2120) GeoRadius support store and storedist option (#2140)
Resolves #2120
Because STORE and STOREDIST return Integer, they are not compatible with GEORADIUS return MultiBulk, so new commands georadiusStore and georadiusByMemberStore have been added.
You can view, comment on, or merge this pull request online at:
#2140
Commit Summary
(#2120) GeoRadius support store and storedist option
File Changes
M src/main/java/redis/clients/jedis/BinaryClient.java (11)
M src/main/java/redis/clients/jedis/BinaryJedis.java (16)
M src/main/java/redis/clients/jedis/BinaryJedisCluster.java (22)
M src/main/java/redis/clients/jedis/BinaryShardedJedis.java (14)
M src/main/java/redis/clients/jedis/Client.java (10)
M src/main/java/redis/clients/jedis/Jedis.java (16)
M src/main/java/redis/clients/jedis/JedisCluster.java (22)
M src/main/java/redis/clients/jedis/PipelineBase.java (28)
M src/main/java/redis/clients/jedis/ShardedJedis.java (14)
M src/main/java/redis/clients/jedis/commands/BinaryJedisClusterCommands.java (6)
M src/main/java/redis/clients/jedis/commands/BinaryJedisCommands.java (6)
M src/main/java/redis/clients/jedis/commands/BinaryRedisPipeline.java (6)
M src/main/java/redis/clients/jedis/commands/JedisClusterCommands.java (6)
M src/main/java/redis/clients/jedis/commands/JedisCommands.java (6)
M src/main/java/redis/clients/jedis/commands/RedisPipeline.java (6)
M src/main/java/redis/clients/jedis/params/GeoRadiusParam.java (27)
M src/test/java/redis/clients/jedis/tests/commands/GeoCommandsTest.java (67)
Patch Links:
https://github.com/xetorthio/jedis/pull/2140.patch
https://github.com/xetorthio/jedis/pull/2140.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@startjava You need to wait for PR to be reviewed and then released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't GEORADIUS with STORE/STOREDIST be considered as multi key operations?
@sazzad16 Yes, GEORADIUS with STORE/STOREDIST should be considered as multi key operations. I plan to modify my PR to put Before that, I want to confirm whether adding I hope you have some suggestions. |
I'm mostly okay with current approach. |
db8e714
to
f295bf7
Compare
I implemented |
f295bf7
to
b216785
Compare
Resolves #2120
Because
STORE
andSTOREDIST
returnInteger
, they are not compatible withGEORADIUS
returnMultiBulk
, so new commandsgeoradiusStore
andgeoradiusByMemberStore
have been added.