Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2120) GeoRadius support store and storedist option #2140

Closed

Conversation

yangbodong22011
Copy link
Collaborator

Resolves #2120
Because STORE and STOREDIST return Integer, they are not compatible with GEORADIUS return MultiBulk, so new commands georadiusStore and georadiusByMemberStore have been added.

@startjava
Copy link

startjava commented Feb 14, 2020 via email

@yangbodong22011
Copy link
Collaborator Author

@startjava You need to wait for PR to be reviewed and then released.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't GEORADIUS with STORE/STOREDIST be considered as multi key operations?

@yangbodong22011
Copy link
Collaborator Author

@sazzad16 Yes, GEORADIUS with STORE/STOREDIST should be considered as multi key operations.

I plan to modify my PR to put georadiusStore and georadiusByMemberStore in MultiKeyCommands.java and MultiKeyJedisClusterCommands.java and MultiKeyPipelineBase .java and their binary versions.

Before that, I want to confirm whether adding georadiusStore and georadiusByMemberStoreis a good way?

I hope you have some suggestions.

@sazzad16
Copy link
Collaborator

@yangbodong22011

Before that, I want to confirm whether adding georadiusStore and georadiusByMemberStoreis a good way?

I'm mostly okay with current approach.

@yangbodong22011
Copy link
Collaborator Author

I implementedgeoradiusStoreandgeoradiusByMemberStoreas multi key commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please implements GeoRadius [STORE key] [STOREDIST key] param!
3 participants