-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #2153 - honor sentinel configuration params within MasterListener
#2159
Conversation
My sincere apologies. I didn't realize that there were already open PRs addressing this issue when I submitted this yesterday. Upon closer inspection, it looks like this PR would handle the scenario more gracefully when the target Sentinel is unavailable (i.e. if |
@timmixell Could you please move all the changes including new Jedis object creation after |
This file seems like it needs a full refactor |
And it seems like we're missing a test to test this use case, |
@gkorland , I'll get one in. I wasn't sure if this PR was going to survive, given that there are a couple other PRs addressing this issue. |
@gkorland I'm struggling a bit on the best approach to write a unit test to support this use case. Do you have any suggestions? Thanks! |
@gkorland Perhaps we can merge it right now and create a new task to write test(s). WDYT? |
I could use some assistance/direction on proper unit test coverage, but I confirmed that the change addresses issue 2153 in our environment. Thank you!
Closes #2124
Resolves #2153