Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and extend ACL implementation #2180

Merged
merged 5 commits into from
May 3, 2020
Merged

Fix and extend ACL implementation #2180

merged 5 commits into from
May 3, 2020

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Apr 14, 2020 •
edited
Loading

To track overall changes since 3.2.0, I'd request to take a look at jedis-3.2.0...sazzad16:user-1

Resolves #2182

@sazzad16 sazzad16 added this to the 3.3.0 milestone Apr 14, 2020
@sazzad16 sazzad16 requested a review from gkorland April 14, 2020 07:14
@sazzad16 sazzad16 self-assigned this Apr 14, 2020
@sazzad16 sazzad16 changed the title Fix/edit ACL implementation Fix and extend ACL implementation Apr 16, 2020
tgrall
tgrall reviewed May 3, 2020
View reviewed changes
Copy link
Contributor

@tgrall tgrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sazzad16 I have reviewed the PR, added some questions/comments.

Thanks for fixing some of the issues I created (missed some stuff, call & sentinel support)

src/main/java/redis/clients/jedis/JedisClusterConnectionHandler.java Show resolved Hide resolved
src/main/java/redis/clients/jedis/JedisClusterInfoCache.java Show resolved Hide resolved
src/main/java/redis/clients/jedis/JedisPool.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/JedisPool.java Show resolved Hide resolved
src/main/java/redis/clients/jedis/JedisSentinelPool.java Show resolved Hide resolved
tgrall
tgrall approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@tgrall tgrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sazzad16
Copy link
Collaborator Author

sazzad16 commented May 3, 2020

@gkorland PING!

@gkorland gkorland merged commit f24a817 into redis:master May 3, 2020
@sazzad16 sazzad16 deleted the user-1 branch May 3, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland approved these changes

@tgrall tgrall tgrall approved these changes

Assignees

@sazzad16 sazzad16

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Use ACL in JedisSentinelPool
3 participants
@sazzad16 @tgrall @gkorland