Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2243 return null when redis returns nil on deleted entries #2244

Merged
merged 1 commit into from
Sep 13, 2020
Merged

fix #2243 return null when redis returns nil on deleted entries #2244

merged 1 commit into from
Sep 13, 2020

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Sep 3, 2020

  1. Return null when Redis returns nil on deleted Entries in XCLAIM
  2. Improve the xpending and xclaim tests

@gkorland gkorland added the bug label Sep 3, 2020
@gkorland gkorland added this to the 3.4.0 milestone Sep 3, 2020
@gkorland gkorland requested a review from sazzad16 September 3, 2020 22:35
@gkorland gkorland self-assigned this Sep 3, 2020
@gkorland
Copy link
Contributor Author

gkorland commented Sep 5, 2020

@sazzad16 I have second thought the implementation, should we return null or just skip those entries?

@sazzad16
Copy link
Collaborator

sazzad16 commented Sep 6, 2020

@gkorland Return null.

Redis Protocol specification

@momomo
Copy link

momomo commented Sep 12, 2020 •
edited
Loading

@gkorland
@sazzad16

can you approve my latest pull request please? Not sure why tests failed, but it has been pending for while now.

#2245

@gkorland gkorland merged commit 91c4445 into master Sep 13, 2020
@gkorland gkorland deleted the NPE_XCLAIM branch September 13, 2020 19:58
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees

@gkorland gkorland

Labels
bug
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gkorland @sazzad16 @momomo