JedisPubSub and BinaryJedisPubSub PING don't support optional argument #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure in Travis CI is unrelated to this PR and addressed in #2223 |
sazzad16
requested changes
Sep 28, 2020
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
sazzad16
requested changes
Sep 28, 2020
sazzad16
approved these changes
Sep 29, 2020
gkorland
reviewed
Oct 13, 2020
gkorland
approved these changes
Dec 6, 2020
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Redis docs at https://redis.io/commands/ping PING takes an optional message, and indeed the Jedis client does have both overloads with and without the message parameter. The overload with message is missing from JedisPubSub and BinaryJedisPubSub.
Relevant issues: