Add ability to reset password in JedisFactory (II) #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JedisSentinelPool
JedisSentinelPool
- Added JedisFactory constructor without host and port as there is option to set those later. - Prepared to private internalPool in Pool.
sazzad16
force-pushed
the
reset-password-JedisFactory-2
branch
from
cd0b2b6
to
3ae050f
Compare
gkorland
suggested changes
Jan 28, 2021
src/test/java/redis/clients/jedis/tests/JedisPoolWithCompleteCredentialsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/JedisPoolWithCompleteCredentialsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/JedisSentinelPoolTest.java
Outdated
Show resolved
Hide resolved
…Factory-2 Conflicts: src/main/java/redis/clients/jedis/JedisFactory.java src/main/java/redis/clients/jedis/JedisPool.java src/main/java/redis/clients/jedis/JedisSentinelPool.java src/main/java/redis/clients/jedis/util/Pool.java
sazzad16
force-pushed
the
reset-password-JedisFactory-2
branch
from
16bcd37
to
dba6f84
Compare
dengliming
reviewed
Mar 15, 2021
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
dengliming
reviewed
Mar 15, 2021
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
dengliming
previously approved these changes
Mar 15, 2021
|
@gkorland @dengliming You can check a quick difference between updating password with and without checking of |
sazzad16
commented
Mar 17, 2021
sazzad16
commented
Mar 17, 2021
sazzad16
commented
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of #2314
Original author: @yapei123 (#1606)
Resolves #1602
Closes #1606
Resolves #533
Closes #2245
Closes #2314