Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a BinaryJedisCluster.Builder #2364

Closed
wants to merge 1 commit into from
Closed

Create a BinaryJedisCluster.Builder #2364

wants to merge 1 commit into from

Conversation

walles
Copy link
Contributor

@walles walles commented Feb 2, 2021

To combat the constructor inflation.

With Java 8 (#2357) we could have used Duration rather than ints for the timeouts which would probably be nicer in the long run.

@walles walles mentioned this pull request Feb 2, 2021
Merged
@sazzad16
Copy link
Collaborator

@walles Currently we're trying to implement config pattern for the entire project (e.g. #2368). So, right now I'd consider only if it is done for all the necessary classes.

@walles
Copy link
Contributor Author

walles commented Feb 16, 2021

Sounds reasonable.

@walles walles closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walles @sazzad16