Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2381 Add GETDEL command #2382

Merged
merged 4 commits into from
Feb 28, 2021
Merged

Fix #2381 Add GETDEL command #2382

merged 4 commits into from
Feb 28, 2021

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland linked an issue Feb 28, 2021 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #2382 (efa9772) into master (9006788) will decrease coverage by 0.06%.
The diff coverage is 32.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2382      +/-   ##
============================================
- Coverage     59.12%   59.06%   -0.07%     
- Complexity     2128     2132       +4     
============================================
  Files            97       97              
  Lines          9975     9999      +24     
  Branches        478      478              
============================================
+ Hits           5898     5906       +8     
- Misses         3880     3897      +17     
+ Partials        197      196       -1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/redis/clients/jedis/BinaryJedis.java 79.94% <0.00%> (-0.23%) 283.00 <0.00> (ø)
...n/java/redis/clients/jedis/BinaryJedisCluster.java 11.00% <0.00%> (-0.05%) 31.00 <0.00> (ø)
...n/java/redis/clients/jedis/BinaryShardedJedis.java 6.63% <0.00%> (-0.04%) 8.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/JedisCluster.java 6.69% <0.00%> (-0.03%) 21.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/PipelineBase.java 12.05% <0.00%> (-0.07%) 43.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/ShardedJedis.java 11.85% <0.00%> (-0.07%) 17.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/BinaryClient.java 93.23% <100.00%> (+0.01%) 323.00 <1.00> (+1.00)
src/main/java/redis/clients/jedis/Client.java 91.57% <100.00%> (+0.02%) 273.00 <1.00> (+1.00)
src/main/java/redis/clients/jedis/Jedis.java 92.43% <100.00%> (+0.02%) 312.00 <1.00> (+1.00)
src/main/java/redis/clients/jedis/Protocol.java 93.12% <100.00%> (ø) 33.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9006788...efa9772. Read the comment docs.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the binary versions.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BinaryJedisCluster.
And almost forgot, Pipeline base.

@sazzad16 sazzad16 added this to the 3.6.0 milestone Feb 28, 2021
@sazzad16 sazzad16 merged commit 55128da into master Feb 28, 2021
@sazzad16 sazzad16 deleted the getdel branch February 28, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GETDEL commands (#8327)
3 participants