Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter types and return types #2396

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Fix parameter types and return types #2396

merged 4 commits into from
Mar 3, 2021

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Mar 2, 2021

Resolves #2374
Resolves #2394

Copy link
Collaborator

@dengliming dengliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@codecov-io
Copy link

Codecov Report

Merging #2396 (bb90095) into master (786f7dc) will decrease coverage by 0.30%.
The diff coverage is 27.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2396      +/-   ##
============================================
- Coverage     59.06%   58.76%   -0.31%     
- Complexity     2132     2137       +5     
============================================
  Files            97      104       +7     
  Lines          9996    10059      +63     
  Branches        477      477              
============================================
+ Hits           5904     5911       +7     
- Misses         3897     3953      +56     
  Partials        195      195              
Impacted Files Coverage Δ Complexity Δ
...n/java/redis/clients/jedis/BinaryJedisCluster.java 10.96% <0.00%> (-0.05%) 31.00 <0.00> (ø)
...n/java/redis/clients/jedis/BinaryShardedJedis.java 6.53% <0.00%> (-0.10%) 8.00 <0.00> (ø)
src/main/java/redis/clients/jedis/Client.java 91.57% <ø> (ø) 273.00 <0.00> (ø)
src/main/java/redis/clients/jedis/Jedis.java 92.43% <ø> (ø) 312.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/JedisCluster.java 6.69% <ø> (ø) 21.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/PipelineBase.java 12.01% <0.00%> (-0.04%) 43.00 <0.00> (ø)
...rc/main/java/redis/clients/jedis/ShardedJedis.java 11.85% <ø> (ø) 17.00 <0.00> (ø)
...nts/jedis/commands/BinaryJedisClusterCommands.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...is/clients/jedis/commands/BinaryRedisPipeline.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/redis/clients/jedis/commands/Commands.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786f7dc...bb90095. Read the comment docs.

@sazzad16 sazzad16 requested a review from gkorland March 2, 2021 11:06
@sazzad16 sazzad16 merged commit 5803200 into master Mar 3, 2021
@sazzad16 sazzad16 deleted the param-mismatch branch March 3, 2021 03:57
This was referenced Mar 3, 2021
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Mar 3, 2021
@sazzad16 sazzad16 mentioned this pull request Mar 3, 2021
sazzad16 added a commit that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants