Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support PXAT/EXAT arguments to SET command #2410

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Add support PXAT/EXAT arguments to SET command #2410

merged 2 commits into from
Mar 9, 2021

Conversation

dengliming
Copy link
Collaborator

Resolves #2386

sazzad16
sazzad16 requested changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Suggested two minor changes.

src/main/java/redis/clients/jedis/params/SetParams.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/params/SetParams.java Outdated Show resolved Hide resolved
@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 9, 2021
@sazzad16 sazzad16 merged commit 9488026 into redis:master Mar 9, 2021
@sazzad16
Copy link
Collaborator

sazzad16 commented Mar 9, 2021

@dengliming Thanks for your contribution!

@dengliming dengliming deleted the set-command branch March 9, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

PXAT/EXAT arguments to SET command (#8327)
2 participants
@dengliming @sazzad16