Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename socket timeout params and builder methods #2422

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Mar 12, 2021

Renamed:

  1. soTimeout -> socketTimeout
    • We don't have to follow naming patterns of Java Socket implementation. Many users don't know there is a Java Socket under the hood and the name and the unit (milliseconds) are coming from there. And they get pretty confused. Longer names should at least decrease some confusion.
  2. infinite -> blocking
    • It should be more descriptive and easier to understand.
  3. Builder methods - removed with prefix
    • The World is moving away from with, use, etc prefixes.

@sazzad16 sazzad16 added this to the 3.6.0 milestone Mar 12, 2021
@sazzad16 sazzad16 requested review from gkorland and mina-asham March 12, 2021 04:58
@sazzad16 sazzad16 force-pushed the blocking-so-timeout branch from 3bd712a to 24e5ef6 Compare March 15, 2021 14:33
@sazzad16 sazzad16 requested a review from dengliming March 15, 2021 14:33
@sazzad16 sazzad16 changed the title Rename infiniteSoTimeout to blockingSoTimeout Rename socket timeout params and builder methods Mar 16, 2021
gkorland
gkorland previously approved these changes Mar 18, 2021
@sazzad16 sazzad16 merged commit e1ad3ba into redis:master Mar 18, 2021
@sazzad16 sazzad16 deleted the blocking-so-timeout branch March 18, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants