-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double timeout, avoid Tuple and more #2481
Conversation
3ad03e6
to
73634b9
Compare
👍 That really should be discussed. and It is weird to see both |
73634b9
to
6ecc579
Compare
6ecc579
to
b7fb270
Compare
I'd suggest splitting the ticket into two topics and avoid breaking changes (return types) until Jedis 4.0. It would also make sense to have an overloaded method accepting |
@mp911de There are no exact breaking changes. For methods that exist in 3.5.2, there are overloading methods. Methods that are seemingly breaking are just merged for 3.6.0. |
I see, thanks. |
src/main/java/redis/clients/jedis/commands/MultiKeyBinaryJedisClusterCommands.java
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/commands/MultiKeyBinaryRedisPipeline.java
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/commands/MultiKeyCommandsPipeline.java
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/commands/MultiKeyJedisClusterCommands.java
Show resolved
Hide resolved
to have common name in both BinaryClient and BinaryJedis
which now have different alternatives
This package contains the classes that represent different Redis command arguments.
(1) Implement
double
timeout:Since Redis 6.0, timeout parameter of some blocking commands now supports
double
instead of integer.(2) Move away from Tuple:
The word Tuple means any finite number of elements. The way it is used not grammatically correct. We should move away from the class, introduce a proper name and avoid introducing wrong usage of the term.
(3) Binary return type:
For binary methods, should we return custom objects or binary array(s)
byte[]
/List<byte[]>
?