Renew cluster slots depends on startNodes (ii) #2644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR solves redis#2551, a problem solving scenario is as follows: 1) JedisCluster jc = new JedisCluster(vip); // now `vip -> ip1` 2) change `vip -> ip2` 3) renewClusterSlots just use getShuffledNodesPool, that is `ip1` 4) connect to `ip1`, and will never connect to `ip2`
| @@ -162,6 +170,19 @@ public void renewClusterSlots(Jedis jedis) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (startNodes != null) { | |||
There was a problem hiding this comment.
If getShuffledNodesPool exists, it is almost impossible for the code to come here unless all master and slave nodes in the cluster are unserviceable.
There was a problem hiding this comment.
@yangbodong22011 OK, now I have clearer idea about #2643
| this(poolConfig, clientConfig, null); | ||
| } | ||
|
|
||
| public JedisClusterInfoCache(final GenericObjectPoolConfig<Jedis> poolConfig, |
There was a problem hiding this comment.
Do you plan to provide an interface for setting JedisClusterInfoCache forJedisCluster?
There was a problem hiding this comment.
I'm not planning such idea.
But I won't mind to see a PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.