Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the BYTE|BIT option for bitcount (binary) #2768

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Added the BYTE|BIT option for bitcount (binary) #2768

merged 3 commits into from
Dec 28, 2021

Conversation

zeekling
Copy link
Contributor

Added the BYTE|BIT option for bitcount

image

sazzad16
sazzad16 reviewed Dec 26, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type for both bitcountByte and bitcountBit is same. IMO, it's better to create a BitCountOption in args package and just do bitcount(key, start, end, bitcountOption).

@zeekling
Copy link
Contributor Author

zeekling commented Dec 26, 2021 •
edited
Loading

done @sazzad16

sazzad16
sazzad16 requested changes Dec 26, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add bitcount(String key, long start, long end, BitCountOption option) variants.

src/main/java/redis/clients/jedis/CommandObjects.java Outdated Show resolved Hide resolved
@sazzad16 sazzad16 changed the title Added the BYTE|BIT option for bitcount Added the BYTE|BIT option for bitcount (binary) Dec 28, 2021
@sazzad16 sazzad16 added this to the 4.1.0 milestone Dec 28, 2021
@sazzad16 sazzad16 merged commit a1abcf3 into redis:master Dec 28, 2021
@sazzad16 sazzad16 mentioned this pull request Dec 28, 2021
Merged
@zeekling zeekling deleted the bitcount branch January 2, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangbodong22011 yangbodong22011 yangbodong22011 approved these changes

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zeekling @sazzad16 @yangbodong22011