Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe in JedisCluster (UnifiedJedis) #2828

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

sazzad16
Copy link
Collaborator

Resolves #2826

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #2828 (0f48b9d) into master (26a682e) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

❗ Current head 0f48b9d differs from pull request most recent head 85e031a. Consider uploading reports for the commit 85e031a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2828      +/-   ##
============================================
- Coverage     58.42%   58.41%   -0.02%     
- Complexity     3050     3052       +2     
============================================
  Files           177      177              
  Lines         10952    10962      +10     
  Branches        628      628              
============================================
+ Hits           6399     6403       +4     
- Misses         4335     4341       +6     
  Partials        218      218              
Impacted Files Coverage Δ
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 62.24% <25.00%> (-0.49%) ⬇️
...in/java/redis/clients/jedis/BinaryJedisPubSub.java 88.09% <100.00%> (+0.59%) ⬆️
src/main/java/redis/clients/jedis/Jedis.java 84.63% <100.00%> (-0.03%) ⬇️
src/main/java/redis/clients/jedis/JedisPubSub.java 70.00% <100.00%> (-1.03%) ⬇️
...nts/jedis/providers/ClusterConnectionProvider.java 74.54% <0.00%> (+1.81%) ⬆️
...in/java/redis/clients/jedis/ConnectionFactory.java 67.34% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a682e...85e031a. Read the comment docs.

@sazzad16 sazzad16 added this to the 4.1.0 milestone Jan 18, 2022
@sazzad16 sazzad16 requested a review from dengliming January 18, 2022 15:02
@sazzad16 sazzad16 merged commit e93e526 into redis:master Jan 18, 2022
@sazzad16 sazzad16 deleted the subscribe-cluster branch January 18, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jedis 4.0.x There is no subscribe method in JedisCluster or it's inherited classes.
3 participants