Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ACL V2 changes #2841

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Address ACL V2 changes #2841

merged 2 commits into from
Jan 26, 2022

Conversation

sazzad16
Copy link
Collaborator

Reference: redis/redis#9974

Alternate implementation: #2840

@sazzad16 sazzad16 added this to the 4.1.0 milestone Jan 25, 2022
@sazzad16 sazzad16 mentioned this pull request Jan 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2841 (1172314) into master (afcce7c) will decrease coverage by 0.07%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2841      +/-   ##
============================================
- Coverage     58.39%   58.31%   -0.08%     
- Complexity     3067     3077      +10     
============================================
  Files           177      177              
  Lines         11011    11084      +73     
  Branches        629      637       +8     
============================================
+ Hits           6430     6464      +34     
- Misses         4363     4398      +35     
- Partials        218      222       +4     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Pipeline.java 9.40% <4.76%> (-0.15%) ⬇️
.../main/java/redis/clients/jedis/BuilderFactory.java 65.71% <33.33%> (-1.25%) ⬇️
...a/redis/clients/jedis/resps/AccessControlUser.java 78.57% <63.63%> (-15.88%) ⬇️
...redis/clients/jedis/DefaultJedisSocketFactory.java 93.42% <87.50%> (-1.82%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 13.71% <94.28%> (+1.19%) ⬆️
src/main/java/redis/clients/jedis/Jedis.java 84.71% <100.00%> (+0.01%) ⬆️
src/main/java/redis/clients/jedis/Protocol.java 87.74% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427a5e4...1172314. Read the comment docs.

@zeekling
Copy link
Contributor

better than #2840

@sazzad16 sazzad16 merged commit 1a451e4 into redis:master Jan 26, 2022
@sazzad16 sazzad16 deleted the acl-change-address-2 branch January 26, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants