Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CLIENT NO-EVICT #2866

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Support CLIENT NO-EVICT #2866

merged 3 commits into from
Feb 3, 2022

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine commented Feb 3, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #2866 (f9d27f2) into master (5359c37) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2866      +/-   ##
============================================
- Coverage     56.28%   56.26%   -0.02%     
  Complexity     3100     3100              
============================================
  Files           187      187              
  Lines         11584    11587       +3     
  Branches        673      674       +1     
============================================
  Hits           6520     6520              
- Misses         4844     4845       +1     
- Partials        220      222       +2     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 84.79% <100.00%> (-0.03%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 87.82% <100.00%> (ø)
...ava/redis/clients/jedis/params/FailoverParams.java 76.19% <0.00%> (-23.81%) ⬇️
src/main/java/redis/clients/jedis/Connection.java 85.35% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5359c37...f9d27f2. Read the comment docs.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid all - issues ATM.

Just add two methods clientNoEvictOn() and clientNoEvictOff() and do

connection.sendCommand(CLIENT, "NO-EVICT", "ON");
connection.sendCommand(CLIENT, "NO-EVICT", "OFF");

@sazzad16 sazzad16 added this to the 4.2.0 milestone Feb 3, 2022
@sazzad16 sazzad16 merged commit 644341b into redis:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants