-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support [NX|XX|GT|LT] options in EXPIREAT and PEXPIREAT #2874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep all At
method together. I.e.
- expireAt(String key, long unixTime);
- expireAt(String key, long unixTime, ExpiryOption expiryOption);
- pexpireAt(String key, long millisecondsTimestamp);
- pexpireAt(String key, long millisecondsTimestamp, ExpiryOption expiryOption);
Codecov Report
@@ Coverage Diff @@
## master #2874 +/- ##
============================================
- Coverage 56.71% 56.56% -0.16%
- Complexity 3148 3152 +4
============================================
Files 189 189
Lines 11699 11727 +28
Branches 676 676
============================================
- Hits 6635 6633 -2
- Misses 4837 4865 +28
- Partials 227 229 +2
Continue to review full report at Codecov.
|
expire(String key, long seconds); expire(String key, long seconds, ExpiryOption expiryOption); pexpire(String key, long milliseconds); pexpire(String key, long milliseconds, ExpiryOption expiryOption); expireTime(String key); pexpireTime(String key); expireAt(String key, long unixTime); expireAt(String key, long unixTime, ExpiryOption expiryOption); pexpireAt(String key, long millisecondsTimestamp); pexpireAt(String key, long millisecondsTimestamp, ExpiryOption expiryOption);
I changed it so now the order of all the expire commands is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it so now the order of all the expire commands is:
...
...
@Avital-Fine You've missed some orderings in Jedis.java and Pipeline.java
No description provided.