Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FUNCTION LOAD changes (from release 7.0 rc3) #2973

Merged
merged 5 commits into from
Apr 10, 2022

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine requested a review from sazzad16 April 7, 2022 13:42
@Avital-Fine Avital-Fine changed the title Update FUNCTION LOAD changes (Release 7.0 rc3) Update FUNCTION LOAD changes (from release 7.0 rc3) Apr 7, 2022
@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2022

This pull request introduces 1 alert when merging 453f103 into a41c7c6 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2022

This pull request introduces 1 alert when merging 458911c into a41c7c6 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avital-Fine Good job. Just one more issue left:

[ERROR] functionList(redis.clients.jedis.commands.jedis.ScriptingCommandsTest)  Time elapsed: 0.006 s  <<< FAILURE!
java.lang.AssertionError: expected:<redis.register_function('myfunc', function(keys, args) return args[1] end)> but was:<null>
	at redis.clients.jedis.commands.jedis.ScriptingCommandsTest.functionList(ScriptingCommandsTest.java:378)

@Avital-Fine Avital-Fine requested a review from sazzad16 April 8, 2022 07:39
@sazzad16 sazzad16 merged commit 3c18734 into redis:master Apr 10, 2022
@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants