Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include QueryBuilder implementations #3107

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Conversation

angelo147
Copy link
Contributor

Regarding #3060 i included the querybuilder package and QueryBuilderTest, also made some internal changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #3107 (a506a7c) into master (d64ad6d) will increase coverage by 14.61%.
The diff coverage is 83.87%.

❗ Current head a506a7c differs from pull request most recent head 2426d1b. Consider uploading reports for the commit 2426d1b to get more accurate results

@@              Coverage Diff              @@
##             master    #3107       +/-   ##
=============================================
+ Coverage     51.89%   66.50%   +14.61%     
- Complexity     3344     4371     +1027     
=============================================
  Files           219      242       +23     
  Lines         13735    14207      +472     
  Branches        795      853       +58     
=============================================
+ Hits           7128     9449     +2321     
+ Misses         6361     4386     -1975     
- Partials        246      372      +126     
Impacted Files Coverage Δ
...s/jedis/search/querybuilder/DisjunctUnionNode.java 0.00% <0.00%> (ø)
...lients/jedis/search/querybuilder/QueryBuilder.java 43.75% <43.75%> (ø)
...lients/jedis/search/querybuilder/DisjunctNode.java 60.00% <60.00%> (ø)
...s/clients/jedis/search/querybuilder/ValueNode.java 72.50% <72.50%> (ø)
...is/clients/jedis/search/querybuilder/GeoValue.java 88.88% <88.88%> (ø)
...edis/clients/jedis/search/querybuilder/Values.java 92.00% <92.00%> (ø)
...s/clients/jedis/search/querybuilder/QueryNode.java 92.30% <92.30%> (ø)
.../clients/jedis/search/querybuilder/RangeValue.java 93.33% <93.33%> (ø)
...ts/jedis/search/querybuilder/DoubleRangeValue.java 100.00% <100.00%> (ø)
...ients/jedis/search/querybuilder/IntersectNode.java 100.00% <100.00%> (ø)
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelo147 Thank you for this PR and sorry for late reply.

Please address the change requests.

@sazzad16 sazzad16 added this to the 4.3.0 milestone Sep 5, 2022
@sazzad16 sazzad16 changed the title Include Querybuilder Include QueryBuilder implementations Sep 5, 2022
@sazzad16 sazzad16 self-requested a review September 8, 2022 16:29
@sazzad16 sazzad16 linked an issue Sep 8, 2022 that may be closed by this pull request
@sazzad16 sazzad16 merged commit ce82171 into redis:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include querybuilder package from JRediSearch
3 participants