Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate package for RedisBloom commands #3112

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

sazzad16
Copy link
Collaborator

Should be considered after #3097

@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Aug 24, 2022
@sazzad16 sazzad16 added this to the 4.3.0 milestone Aug 24, 2022
@sazzad16 sazzad16 marked this pull request as draft August 24, 2022 07:22
@codecov-commenter
Copy link

Codecov Report

Merging #3112 (61eb71c) into master (9a69fb3) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 61eb71c differs from pull request most recent head 3132453. Consider uploading reports for the commit 3132453 to get more accurate results

@@             Coverage Diff              @@
##             master    #3112      +/-   ##
============================================
- Coverage     66.75%   66.69%   -0.06%     
+ Complexity     4465     4233     -232     
============================================
  Files           245      219      -26     
  Lines         14453    13740     -713     
  Branches        884      795      -89     
============================================
- Hits           9648     9164     -484     
+ Misses         4425     4244     -181     
+ Partials        380      332      -48     
Impacted Files Coverage Δ
...s/jedis/bloom/commands/CountMinSketchCommands.java 100.00% <ø> (ø)
...lients/jedis/executors/ClusterCommandExecutor.java 78.46% <0.00%> (-6.62%) ⬇️
...ain/java/redis/clients/jedis/search/FieldName.java 61.53% <0.00%> (-4.38%) ⬇️
...java/redis/clients/jedis/params/SortingParams.java 81.25% <0.00%> (-3.13%) ⬇️
...in/java/redis/clients/jedis/timeseries/TSInfo.java 90.76% <0.00%> (-0.79%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.63% <0.00%> (-0.27%) ⬇️
.../main/java/redis/clients/jedis/CommandObjects.java 84.70% <0.00%> (-0.19%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.24% <0.00%> (-0.19%) ⬇️
...ava/redis/clients/jedis/search/SearchProtocol.java 97.50% <0.00%> (-0.18%) ⬇️
src/main/java/redis/clients/jedis/Pipeline.java 17.20% <0.00%> (-0.12%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sazzad16 sazzad16 marked this pull request as ready for review September 20, 2022 06:26
@sazzad16 sazzad16 merged commit b668413 into redis:master Sep 20, 2022
@sazzad16 sazzad16 deleted the bloom-commands-package branch September 20, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants