Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ASC and DESC keywords #3136

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Conversation

sazzad16
Copy link
Collaborator

After introducing SortingOrder argument, these keywords are not needed in codebase.

After introducing SortingOrder argument, these keywords are not needed in codebase.
@sazzad16 sazzad16 added this to the 4.3.0 milestone Sep 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3136 (322a901) into master (2daa110) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3136   +/-   ##
=========================================
  Coverage     66.52%   66.52%           
- Complexity     4382     4383    +1     
=========================================
  Files           243      243           
  Lines         14223    14223           
  Branches        851      851           
=========================================
  Hits           9462     9462           
+ Misses         4390     4389    -1     
- Partials        371      372    +1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Protocol.java 91.87% <100.00%> (+1.25%) ⬆️
...in/java/redis/clients/jedis/JedisSentinelPool.java 65.89% <0.00%> (-1.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sazzad16 sazzad16 merged commit 71dd808 into redis:master Sep 11, 2022
@sazzad16 sazzad16 deleted the asc-desc-keyword branch September 11, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants