Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null property value parsing of search document #3148

Merged
merged 3 commits into from
Sep 25, 2022

Conversation

sazzad16
Copy link
Collaborator

when it was:

  • set from outside Jedis
  • not carried by JSONObject
  • not serialized by default Gson

when it was:
- set from outside Jedis
- not carried by JSONObject
- not serialized by _default_ Gson
@codecov-commenter
Copy link

Codecov Report

Base: 66.68% // Head: 66.78% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (752add7) compared to base (899eb05).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3148      +/-   ##
============================================
+ Coverage     66.68%   66.78%   +0.09%     
- Complexity     4495     4502       +7     
============================================
  Files           246      246              
  Lines         14545    14549       +4     
  Branches        887      887              
============================================
+ Hits           9700     9716      +16     
+ Misses         4462     4453       -9     
+ Partials        383      380       -3     
Impacted Files Coverage Δ
...main/java/redis/clients/jedis/search/Document.java 83.33% <100.00%> (+1.75%) ⬆️
.../java/redis/clients/jedis/search/SearchResult.java 100.00% <100.00%> (ø)
src/main/java/redis/clients/jedis/Protocol.java 91.87% <0.00%> (+1.25%) ⬆️
...ava/redis/clients/jedis/JedisClusterInfoCache.java 74.35% <0.00%> (+1.28%) ⬆️
src/main/java/redis/clients/jedis/JedisPubSub.java 71.81% <0.00%> (+1.81%) ⬆️
...nts/jedis/providers/ClusterConnectionProvider.java 78.18% <0.00%> (+5.45%) ⬆️
...lients/jedis/search/schemafields/NumericField.java 78.94% <0.00%> (+15.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 1b9ee96 into redis:master Sep 25, 2022
@sazzad16 sazzad16 deleted the doc-json-null branch September 25, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ftSearch fails with NullPointerException when reading a json element with null value
2 participants