Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GenericObjectPool usages #3186

Merged
merged 3 commits into from
Oct 30, 2022

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@sazzad16 sazzad16 added this to the 4.4.0 milestone Oct 30, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 66.76% // Head: 66.71% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (365c882) compared to base (c4988b2).
Patch coverage: 70.73% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3186      +/-   ##
============================================
- Coverage     66.76%   66.71%   -0.05%     
- Complexity     4528     4530       +2     
============================================
  Files           247      247              
  Lines         14628    14644      +16     
  Branches        893      895       +2     
============================================
+ Hits           9766     9770       +4     
- Misses         4475     4487      +12     
  Partials        387      387              
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/JedisPooled.java 27.34% <41.66%> (-5.73%) ⬇️
src/main/java/redis/clients/jedis/JedisPool.java 59.52% <50.00%> (-0.32%) ⬇️
.../main/java/redis/clients/jedis/ConnectionPool.java 100.00% <100.00%> (+36.36%) ⬆️
...ava/redis/clients/jedis/JedisClusterInfoCache.java 74.35% <100.00%> (ø)
...in/java/redis/clients/jedis/JedisSentinelPool.java 67.03% <100.00%> (+1.14%) ⬆️
...ents/jedis/providers/PooledConnectionProvider.java 94.44% <100.00%> (ø)
...nts/jedis/providers/ShardedConnectionProvider.java 76.05% <100.00%> (ø)
src/main/java/redis/clients/jedis/util/Pool.java 68.42% <100.00%> (+1.75%) ⬆️
...nts/jedis/providers/ClusterConnectionProvider.java 74.54% <0.00%> (-3.64%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 338f5d3 into redis:master Oct 30, 2022
@sazzad16 sazzad16 deleted the refactor-GenericObjectPool-use branch October 30, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants