Adding Javadocs to Jedis 'args' package #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 66.90% // Head: 66.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3210 +/- ##
============================================
- Coverage 66.90% 66.86% -0.04%
+ Complexity 4546 4543 -3
============================================
Files 248 248
Lines 14738 14742 +4
Branches 916 916
============================================
- Hits 9860 9857 -3
- Misses 4487 4492 +5
- Partials 391 393 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chayim
changed the title
sazzad16
requested changes
Nov 28, 2022
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| import redis.clients.jedis.util.SafeEncoder; | |||
|
|
|||
| /** | |||
| * The args for the command bitcount | |||
There was a problem hiding this comment.
Suggested change
| * The args for the command bitcount | |
| * The options for {@code BITCOUNT} command. |
src/main/java/redis/clients/jedis/args/ClusterFailoverOption.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/args/ClusterFailoverOption.java
Outdated
Show resolved
Hide resolved
zeekling
changed the title
sazzad16
requested changes
Dec 4, 2022
src/main/java/redis/clients/jedis/args/ClusterFailoverOption.java
Outdated
Show resolved
Hide resolved
sazzad16
requested changes
Dec 4, 2022
src/main/java/redis/clients/jedis/args/ClusterFailoverOption.java
Outdated
Show resolved
Hide resolved
sazzad16
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add doc for jedis