Avoid using QUIT command #3377
Merged
Avoid using QUIT command #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Jedis avoid using QUIT command Please refer to: redis/redis#11420 This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface `Jedis.quit()`. This optimizes Jedis connection pool performance and fixes: redis#2105 * Update src/main/java/redis/clients/jedis/Connection.java Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com> --------- Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com> --------- Conflicts: src/main/java/redis/clients/jedis/Connection.java src/main/java/redis/clients/jedis/ConnectionFactory.java src/main/java/redis/clients/jedis/Jedis.java src/main/java/redis/clients/jedis/Protocol.java
|
The other code LGTM. |
yangbodong22011
approved these changes
Apr 20, 2023
|
Hello! Thank you for backport. But could you explain please why did you revert changes for sharded classes? |
|
@rogoza-igor Tests were failing. We tried some quick approaches but couldn't succeed. As the concerned classes were removed in Jedis 4.0.0 anyway, we did not invest much time and reverted the change to make the code as it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3353
Please refer to: redis/redis#11420
This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface
Jedis.quit(). This optimizes Jedis connection pool performance and fixes: #2105