Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly disconnected connections are set as broken #3381

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Apr 27, 2023

Address 'Avoid using QUIT command (#3353)'

Imported from #3380

@sazzad16 sazzad16 added this to the 4.4.0 milestone Apr 27, 2023
@sazzad16 sazzad16 changed the title Address 'Avoid using QUIT command (#3353)' (newly) disconnected connections are set as broken Apr 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (e0f0357) 67.23% compared to head (229465d) 67.23%.

❗ Current head 229465d differs from pull request most recent head fbee0f4. Consider uploading reports for the commit fbee0f4 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3381   +/-   ##
=========================================
  Coverage     67.23%   67.23%           
  Complexity     4728     4728           
=========================================
  Files           269      269           
  Lines         15273    15274    +1     
  Branches        964      964           
=========================================
+ Hits          10269    10270    +1     
- Misses         4584     4585    +1     
+ Partials        420      419    -1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Connection.java 81.69% <75.00%> (+1.42%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 changed the title (newly) disconnected connections are set as broken Newly disconnected connections are set as broken Apr 27, 2023
@sazzad16 sazzad16 removed the request for review from yangbodong22011 April 27, 2023 13:29
@sazzad16 sazzad16 merged commit 52a10e1 into redis:master Apr 27, 2023
@sazzad16 sazzad16 deleted the address-3353 branch April 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants