Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements for RESP3 and version validation #3416

Closed
wants to merge 8 commits into from
Closed

Conversation

chayim
Copy link
Contributor

@chayim chayim commented May 15, 2023

No description provided.

@chayim chayim changed the base branch from master to 5.0 May 15, 2023 06:40
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -17.17 ⚠️

Comparison is base (ad46481) 67.66% compared to head (7c8c80f) 50.50%.

❗ Current head 7c8c80f differs from pull request most recent head 0195d90. Consider uploading reports for the commit 0195d90 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff              @@
##                5.0    #3416       +/-   ##
=============================================
- Coverage     67.66%   50.50%   -17.17%     
+ Complexity     4756     3615     -1141     
=============================================
  Files           274      274               
  Lines         15242    15242               
  Branches        980      980               
=============================================
- Hits          10314     7698     -2616     
- Misses         4500     7244     +2744     
+ Partials        428      300      -128     

see 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim marked this pull request as ready for review May 16, 2023 12:45
@chayim
Copy link
Contributor Author

chayim commented May 16, 2023

@sazzad16 This now fails on a per redis basis. Can we limit the tests it runs? This is the part I'd love your help on...

@sazzad16
Copy link
Collaborator

@chayim Sure. Let's discuss how we want to limit...

@sazzad16 sazzad16 changed the base branch from 5.0 to master September 14, 2023 10:36
@chayim
Copy link
Contributor Author

chayim commented Jan 2, 2024

Supplanted in existing release.

@chayim chayim closed this Jan 2, 2024
@sazzad16 sazzad16 deleted the ck-redvers branch January 2, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants