Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TimeSeries commands after RESP3 update #3417

Merged
merged 15 commits into from
Jun 1, 2023

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental labels May 15, 2023
@sazzad16 sazzad16 changed the title Update TimeSeries commands after RESP3 update Modify TimeSeries commands after RESP3 update May 15, 2023
@sazzad16 sazzad16 requested review from chayim and uglide May 15, 2023 13:57
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Patch coverage: 83.23% and project coverage change: +3.17 🎉

Comparison is base (c2634a4) 67.98% compared to head (76ab9a6) 71.16%.

❗ Current head 76ab9a6 differs from pull request most recent head 907fd5d. Consider uploading reports for the commit 907fd5d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3417      +/-   ##
============================================
+ Coverage     67.98%   71.16%   +3.17%     
- Complexity     4544     4742     +198     
============================================
  Files           275      275              
  Lines         14603    14748     +145     
  Branches        977      998      +21     
============================================
+ Hits           9928    10495     +567     
+ Misses         4264     3816     -448     
- Partials        411      437      +26     
Impacted Files Coverage Δ
...rc/main/java/redis/clients/jedis/PipelineBase.java 27.03% <ø> (ø)
...main/java/redis/clients/jedis/TransactionBase.java 12.47% <ø> (ø)
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 74.58% <ø> (+2.81%) ⬆️
.../redis/clients/jedis/timeseries/TSMGetElement.java 40.00% <40.00%> (ø)
.../main/java/redis/clients/jedis/BuilderFactory.java 75.06% <71.42%> (-0.14%) ⬇️
...dis/clients/jedis/timeseries/TSMRangeElements.java 73.33% <73.33%> (ø)
...nts/jedis/timeseries/TimeSeriesBuilderFactory.java 85.50% <86.53%> (+85.50%) ⬆️
.../main/java/redis/clients/jedis/CommandObjects.java 85.88% <91.66%> (+3.58%) ⬆️
...in/java/redis/clients/jedis/timeseries/TSInfo.java 93.27% <95.83%> (+93.27%) ⬆️
...edis/clients/jedis/timeseries/AggregationType.java 87.50% <100.00%> (+87.50%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 changed the base branch from 5.0 to master May 18, 2023 12:49
@sazzad16 sazzad16 added this to the 5.0.0 milestone May 23, 2023
@sazzad16 sazzad16 marked this pull request as draft May 28, 2023 18:28
@sazzad16 sazzad16 force-pushed the timeseries-resp3 branch from 0c8514c to 0e5c5d8 Compare May 31, 2023 16:28
@sazzad16 sazzad16 force-pushed the timeseries-resp3 branch from bf983c4 to 1cefabe Compare June 1, 2023 07:58
@sazzad16 sazzad16 marked this pull request as ready for review June 1, 2023 08:51
@sazzad16 sazzad16 merged commit 0f760bc into redis:master Jun 1, 2023
@sazzad16 sazzad16 deleted the timeseries-resp3 branch June 1, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants