Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON.MERGE Command #3429

Merged
merged 28 commits into from
May 29, 2023

Conversation

shacharPash
Copy link
Contributor

Closes #3395

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.05 ⚠️

Comparison is base (5164a89) 68.07% compared to head (d3d318f) 68.02%.

❗ Current head d3d318f differs from pull request most recent head 6b56d90. Consider uploading reports for the commit 6b56d90 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3429      +/-   ##
============================================
- Coverage     68.07%   68.02%   -0.05%     
- Complexity     4543     4546       +3     
============================================
  Files           275      275              
  Lines         14597    14607      +10     
  Branches        978      978              
============================================
  Hits           9937     9937              
- Misses         4248     4256       +8     
- Partials        412      414       +2     
Impacted Files Coverage Δ
...rc/main/java/redis/clients/jedis/PipelineBase.java 27.03% <0.00%> (-0.07%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 12.47% <0.00%> (-0.03%) ⬇️
...va/redis/clients/jedis/json/RedisJsonCommands.java 87.50% <ø> (ø)
.../clients/jedis/json/RedisJsonPipelineCommands.java 37.50% <ø> (ø)
.../main/java/redis/clients/jedis/CommandObjects.java 82.35% <100.00%> (+0.03%) ⬆️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.77% <100.00%> (+0.15%) ⬆️
...in/java/redis/clients/jedis/json/JsonProtocol.java 96.29% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash changed the title Sp/jedis/support json.merge Support JSON.MERGE Command May 21, 2023
@shacharPash shacharPash marked this pull request as ready for review May 21, 2023 14:08
@shacharPash shacharPash requested a review from sazzad16 May 24, 2023 11:22
@shacharPash shacharPash requested a review from sazzad16 May 28, 2023 11:03
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Resolve the conflicts now.

@sazzad16 sazzad16 added this to the 5.0.0 milestone May 28, 2023
@sazzad16 sazzad16 merged commit a6ec2b9 into redis:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON.MERGE
3 participants