Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Keyword(s) in params classes #3434

Merged
merged 8 commits into from
May 26, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

  • Removed Params abstract class.

Resolves #2303

- Removed `Params` abstract class.
@sazzad16 sazzad16 added wait for more reviews breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. labels May 23, 2023
@sazzad16 sazzad16 added this to the 5.0.0 milestone May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage: 84.65% and project coverage change: -0.16 ⚠️

Comparison is base (9e21013) 68.22% compared to head (032b782) 68.06%.

❗ Current head 032b782 differs from pull request most recent head dd8010f. Consider uploading reports for the commit dd8010f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3434      +/-   ##
============================================
- Coverage     68.22%   68.06%   -0.16%     
+ Complexity     4529     4504      -25     
============================================
  Files           274      273       -1     
  Lines         14456    14360      -96     
  Branches        983      960      -23     
============================================
- Hits           9862     9774      -88     
- Misses         4181     4184       +3     
+ Partials        413      402      -11     
Impacted Files Coverage Δ
.../java/redis/clients/jedis/params/BitPosParams.java 100.00% <ø> (ø)
...redis/clients/jedis/params/ModuleLoadExParams.java 0.00% <0.00%> (ø)
...ava/redis/clients/jedis/params/ShutdownParams.java 0.00% <0.00%> (ø)
.../java/redis/clients/jedis/params/LolwutParams.java 63.63% <33.33%> (+13.63%) ⬆️
...edis/clients/jedis/params/GeoRadiusStoreParam.java 52.63% <50.00%> (ø)
.../java/redis/clients/jedis/params/XClaimParams.java 50.00% <50.00%> (ø)
...ava/redis/clients/jedis/params/XPendingParams.java 73.80% <66.66%> (+4.92%) ⬆️
...ava/redis/clients/jedis/params/FailoverParams.java 88.88% <75.00%> (-0.59%) ⬇️
...ava/redis/clients/jedis/params/GeoRadiusParam.java 90.24% <75.00%> (-2.26%) ⬇️
...ain/java/redis/clients/jedis/params/LCSParams.java 81.81% <75.00%> (ø)
... and 24 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit bad2394 into redis:master May 26, 2023
@sazzad16 sazzad16 deleted the keywords-in-params branch May 26, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Keywords in Param classes
3 participants